New Message: [bug] manilaSuite.discuss.rss.getRss

[webmaster at userland.com]

A new message was posted:

Address: http://manila.userland.com/discuss/msgReader$2845

By: Steve Hooker (steve at cybersaps.com)

When an enclosure has an ampersand in its URL, the whole feed isn't validated. Firefox hates it as does iTunes.

In manilaSuite.discuss.rss.getRss there is no checking of the URL, it's just added as it's found in the message table's enclosure table.

In manilaSuite.discuss.rss.getRss, before the line:

add ("<enclosure url=\"" + adrEnclosure^.url + "\" length=\"" + adrEnclosure^.length + "\" type=\"" + adrEnclosure^.type + "\" />")

Add in some checking and a sanity check thus:

local {
 urlClean = adrEnclosure^.url};
if urlClean contains "&" {
 urlClean = string.replaceAll (urlClean, "&", "&");
 urlClean = entityEncode (urlClean)};
add ("<enclosure url=\"" + urlClean + "\" length=\"" + adrEnclosure^.length + "\" type=\"" + adrEnclosure^.type + "\" />")

Steve Steve Hooker

http://www.blogfrootball.com/service

http://www.walsallschools.org/

This is a Manila site... http://manila.userland.com/.